Makecheck debuginfo arm linux androideabi #10261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
in order to debuginfo test of make check(arm-linux-androideabi) |
| @@ -219,6 +219,19 @@ pub fn mode_str(mode: mode) -> ~str { | |||
| } | |||
|
|
|||
| pub fn run_tests(config: &config) { | |||
| if config.target.equals(&~"arm-linux-androideabi"){ | |||
There was a problem hiding this comment.
Is there some problem with config.target == ~"arm-linux-androideabi", or (preferably) "arm-linux-androideabi" == config.target?
|
There appears to be an empty file added: Also, the rust convention is for spacing like |
| } | ||
|
|
||
| if ProcRes.status != 0 { | ||
| fatal(~"gdb failed to execute"); |
|
Nice work @ksh8281! I love improvements to the test suite. |
|
This needs to be rebased on top of master again. |
bors
added a commit
that referenced
this pull request
Nov 6, 2013
…roideabi, r=brson In order to pass make check on android target credit to @ksh8281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to pass make check on android target
credit to @ksh8281